Deprecate LLVM::Module#write_bitcode_with_summary_to_file
#13488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
force-pushed
the
refactor/write_bitcode_with_summary_to_file
branch
from
f6e5e48 to
3d79566
Compare
|
Why not remove it altogether? |
straight-shoota
approved these changes
May 22, 2023
|
@Sija Because the |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crystal never calls this method (nor
#write_bitcode_to_filenor#write_bitcode_to_fd, for that matter), and ThinLTO is already gone, so there is no harm in making#write_bitcode_with_summary_to_filebehave identically to#write_bitcode_to_file.